Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json-patch to 2.0.0 #1503

Closed
clux opened this issue May 27, 2024 · 1 comment · Fixed by #1507
Closed

Update json-patch to 2.0.0 #1503

clux opened this issue May 27, 2024 · 1 comment · Fixed by #1507
Assignees
Labels
dependencies upgrades to dependencies help wanted Not immediately prioritised, please help!

Comments

@clux
Copy link
Member

clux commented May 27, 2024

Failing finalizer helper stuff via dependabot ignored PR in #1493.

Seems to want different types for patch operations. Many errors like:

error[E0308]: mismatched types
   --> kube-runtime/src/finalizer.rs:144:68
    |
144 |                     PatchOperation::Remove(RemoveOperation { path: finalizer_path }),
    |                                                                    ^^^^^^^^^^^^^^ expected `Pointer`, found `String`

See https://github.com/idubrov/json-patch (the changelog is out of date, and no release notes afaikt).

Don't have time to look at it now so leaving it open. Would be good to tackle because people might confuse it with a kube problem that finalizer api does not work if they are able to build with multiple deps ala #1490.

@clux clux added help wanted Not immediately prioritised, please help! good first issue Good for newcomers dependencies upgrades to dependencies labels May 27, 2024
@clux clux removed the good first issue Good for newcomers label May 27, 2024
@bobsongplus
Copy link
Contributor

bobsongplus commented May 30, 2024

/assign I'm new to the project and like to try to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies upgrades to dependencies help wanted Not immediately prioritised, please help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants