-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update json-patch to 2.0.0 #1507
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
=======================================
- Coverage 75.1% 75.0% -0.0%
=======================================
Files 78 78
Lines 6864 6871 +7
=======================================
Hits 5150 5150
- Misses 1714 1721 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this. Generally looks sensible 👍
Left a few comments. Need to be a bit careful here because it is kind of manually tested.
There is an example secret_syncer
that can test this (along with its configmap that can be applied/deleted while it is running), are you able to run it to see if it still works?
Thanks for taking the time to review so quickly. I will test it to see if it works or not. |
5ec957e
to
b8209a0
Compare
2a896e0
to
30f79a7
Compare
bae7021
to
03f8193
Compare
there are some test errors needed to be fixed . |
@clux thanks for taking some time to review again. All comments are fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. Looks more sensible. Just 2 small nits here for dependency optimisation and doc cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks a lot!
(i see rustfmt is technically red, if you have a minute to re-run it, that'd be great, otherwise i'll merge it tomorrow and have ci autocorrect it) |
Signed-off-by: song <tinysong1226@gmail.com>
Yeah, sorry for that I forgot to execute |
Motivation
Fix: #1503
Solution