WIP: Add app labels where applicable for redis #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenlj
approved these changes
Jun 11, 2024
Reasonable-Solutions
force-pushed
the
app-labels-redis
branch
from
6d17f13 to
5a56ea8
Compare
| } | ||
|
|
||
| fn replace_patch(path: String, value: Value) -> PatchOperation { | ||
| PatchOperation::Replace(json_patch::ReplaceOperation { path, value }) | ||
| PatchOperation::Replace(json_patch::ReplaceOperation { | ||
| path: Pointer::from_str(&path).unwrap(), |
There was a problem hiding this comment.
Carl, come on..
There was a problem hiding this comment.
Suggested change
| path: Pointer::from_str(&path).unwrap(), | |
| path: Pointer::new(path.split("/").skip(1).collect::<Vec<_>>()), |
If it's the unwrap() you wanna get rid of =)
EDIT: Forgot to skip the first ["", "foo", "bar"], if one "/foo/bar".split().
Bumps [json-patch](https://github.com/idubrov/json-patch) from 1.2.0 to 2.0.0. - [Changelog](https://github.com/idubrov/json-patch/blob/main/CHANGELOG.md) - [Commits](idubrov/json-patch@v1.2.0...v2.0.0) --- updated-dependencies: - dependency-name: json-patch dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump schematic from 0.15.2 to 0.16.4 Bumps [schematic](https://github.com/moonrepo/schematic) from 0.15.2 to 0.16.4. - [Changelog](https://github.com/moonrepo/schematic/blob/master/CHANGELOG.md) - [Commits](moonrepo/schematic@schematic-v0.15.2...schematic-v0.16.4) --- updated-dependencies: - dependency-name: schematic dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Reasonable-Solutions
force-pushed
the
app-labels-redis
branch
from
5a56ea8 to
a3e0c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To populate the app row for costs that are redis in the bigquery costs table we need to set the app label to the app that owns the redis. First I just need to do some dependabot chores. The Kube-core library that we depend on depends on json-patch 1.4 as we used to and we have bumped to 2.0 which means that we are waiting on an upstream pr to kube core. Said pr exists and will most likely be merged shortly tho.
kube-rs/kube#1507
^ That pr