Add implicit runner inside Reflector #151
Comments
clux
added a commit
that referenced
this issue
Apr 6, 2020
fixes #151 and fixes #152 with tokio::signal and a futures::select call. drops a lot of Reflector logic to defer to Informer. Seems to work pretty well, but may need to deal with desyncs better. Ran into the unordered resourceVersion issue on a really old namespace. Need to double check if that can happen with old version.
clux
added a commit
that referenced
this issue
Apr 7, 2020
fixes #151 and fixes #152 with tokio::signal and a futures::select call. drops a lot of Reflector logic to defer to Informer. Seems to work pretty well, but may need to deal with desyncs better. Ran into the unordered resourceVersion issue on a really old namespace. Need to double check if that can happen with old version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To avoid people having to do this type of task spawning just to ensure a reflector is up to date:
https://github.com/babylonhealth/shipcat/blob/fd78055e795017b276eb99de3ecc86a2f99eab86/raftcat/src/state.rs#L184-L207
There's no reason why people NEED to do this themselves. It should be encapsulated herein if possible.
This should also be integrated with signal handlers in the future. But making a separate issue for that.
The text was updated successfully, but these errors were encountered: