Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflector store sometimes stores multiple instances of the same object #286

Closed
nightkr opened this issue Jul 23, 2020 · 1 comment · Fixed by #287
Closed

Reflector store sometimes stores multiple instances of the same object #286

nightkr opened this issue Jul 23, 2020 · 1 comment · Fixed by #287
Assignees
@nightkr
Labels
runtime controller runtime related

Comments

@nightkr
Copy link
Member

nightkr commented Jul 23, 2020 •
edited
Loading

This seems to be a bug in dashmap 4.0.0-rc6 where an insert for an existing key may create a new entry rather than update the existing one.
@nightkr nightkr added the runtime controller runtime related label Jul 23, 2020
@nightkr nightkr self-assigned this Jul 23, 2020
@nightkr nightkr changed the title Reflector store sometimes stores multiple instances of the same key Reflector store sometimes stores multiple instances of the same object Jul 23, 2020
nightkr added a commit to Appva/kube-rs that referenced this issue Jul 23, 2020
@nightkr
Downgrade dashmap to 3.11.7
2e08615 
Fixes kube-rs#286
nightkr added a commit to Appva/kube-rs that referenced this issue Jul 23, 2020
@nightkr
Test store integrity
5c700ea 
To ensure that kube-rs#286 doesn't pop back up
@clux
Copy link
Member

clux commented Jul 23, 2020 •
edited
Loading

I might have been a bit hasty with the upgrade. The latest 3.X release should be easy to swap in with no code changes.

EDIT: Ah, see you are doing this.

This was referenced Jul 23, 2020
Merged
Closed
@clux clux closed this as completed in #287 Jul 23, 2020
@nightkr nightkr mentioned this issue Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightkr nightkr

Labels
runtime controller runtime related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Downgrade Dashmap to 3.11.7 to fix store duplicates Appva/kube-rs
2 participants
@clux @nightkr