Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a config feature in kube #533

Closed
clux opened this issue May 21, 2021 · 1 comment · Fixed by #535
Closed

create a config feature in kube #533

clux opened this issue May 21, 2021 · 1 comment · Fixed by #535
Assignees

Comments

@clux
Copy link
Member

clux commented May 21, 2021

We currently have a "private" __config feature in kube to track the config related dependencies.

I would like to expose this properly so that people can use kube with only the config feature to deal with kubeconfig related parsing.

This would require:

  • having checks for #[cfg(feature = "config") for the config module
  • having config feature depend on internal __non_core feature
  • having checks for #[cfg(feature = "config") or #[cfg(feature = "client") (or possibly feature = __non_core?) for overlapping deps
  • having the error enum be more feature flagged (currently entire module is gated on client feature)
  • a small test example that parser kubeconfig without features (needs some feature-re-export hackery in examples/Cargo.toml, plus a circleci test line)

You should not be able to get the client feature without the config feature (already ensured by having __config feature listed as a dependency of the client feature), but the other way around should work.

@clux clux self-assigned this May 21, 2021
clux added a commit that referenced this issue May 21, 2021
@clux clux linked a pull request May 21, 2021 that will close this issue
@clux clux closed this as completed in #535 May 21, 2021
clux added a commit that referenced this issue May 21, 2021
add a config feature in kube - fixes #533
kazk pushed a commit to kazk/kube-rs that referenced this issue May 31, 2021
@clux
Copy link
Member Author

clux commented Jun 5, 2021

released in 0.56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant