Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional rustls support #66

Closed
jnicholls opened this issue Aug 30, 2019 · 6 comments
Closed

Optional rustls support #66

jnicholls opened this issue Aug 30, 2019 · 6 comments
Labels
config Kube config related help wanted Not immediately prioritised, please help!

Comments

@jnicholls
Copy link

Some Rust users in the community are not interested in having OpenSSL as a dependency. Especially just for the support of loading certificate/key data from kubeconfig files. reqwest already supports rustls as an optional feature instead of using native-tls. You would simply need to switch the cert/key loading to only use reqwest Certificate/Identity APIs, and potentially rustls::internal::pemfile if necessary, rather than the openssl crate.

@clux
Copy link
Member

clux commented Aug 30, 2019

Yeah, I would be very happy to have rustls as a feature (even having it as the default feature if it works well). Reqwest dependency is easy to switch out. My time is somewhat limited here, but would gladly take a PR for rustls support in the config module.

@clux
Copy link
Member

clux commented Jan 31, 2020

@jnicholls I've tried following your plan in #114 using some of @ctron 's linked commit (ty). Unfortunately, have not been able to make it communicate with a cluster yet (just getting 403s back). My pem input + cert bundles all seem sensible afaikt, but have very little knowledge in this area. Any help to make this work would be appreciated.

@clux clux removed their assignment Jan 31, 2020
@jnicholls
Copy link
Author

@clux Thanks for jumping into this! You are amazing for creating and supporting this great library and just wanted to start with a big thank you.

This afternoon I will find some time to jump in here and see if I can lend a hand!

@clux
Copy link
Member

clux commented Jan 31, 2020

Appreciate that! Just a heads up that the rustls issue is actually more or less resolved! Just need to tidy it up a bit for a release and port the oauth module.

Any more of the help that you've already jump on or want to jump on is still very much appreciated though!

@clux
Copy link
Member

clux commented Feb 1, 2020

Initial support in master. Will release a version with it soon. But it's probably not usable for gke yet: see #120

@clux clux closed this as completed Feb 1, 2020
@clux
Copy link
Member

clux commented Feb 9, 2020

Released in 0.25.0 along with a great pr to help #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Kube config related help wanted Not immediately prioritised, please help!
Projects
None yet
Development

No branches or pull requests

2 participants