Adds example to Controller::watches
#1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
watches-doc
branch
2 times, most recently
from
3e3bc01 to
799b990
Compare
clux
reviewed
Sep 26, 2022
clux
reviewed
Sep 26, 2022
clux
reviewed
Sep 26, 2022
clux
reviewed
Sep 26, 2022
Dav1dde
force-pushed
the
watches-doc
branch
from
799b990 to
116f6fa
Compare
|
Rendered: I also added in the text (marked red) locally, what do you think? |
|
Looks great. Thanks a lot! |
clux
approved these changes
Sep 27, 2022
Dav1dde
force-pushed
the
watches-doc
branch
from
116f6fa to
138c797
Compare
Closes kube-rs#1016 Signed-off-by: David Herberth <github@dav1d.de>
Dav1dde
force-pushed
the
watches-doc
branch
from
138c797 to
ce4cc24
Compare
|
I added the text (same as in the screenshot) and rebased to main |
clux
added
docs
clux
changed the title
Controller::watches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1016
Adds an example for
Controller::watchesusing the Operator-SDK Annotations.I think we could add a reference to the operator docs and a small description, but I am not good at wording it.