add fieldManager querystring to all operations #1031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Not too sure if the fieldManager was intentionally not set or just forgotten, but the *Params struct accepted a field_manager and never used it. I noticed this when I used the
replace
function with a PostParams that had field_manager set, but the resulting YAML after the update hadunknown
on themanager
field, instead of the name of my app.Solution
set the fieldManager for create/update/replace operations just like patch does.