Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A warning on api version preference being a group concept #1295

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

clux
Copy link
Member

@clux clux commented Sep 11, 2023

Closes #1289 and documents a common footgun.

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-exclude changelog excluded prs label Sep 11, 2023
@clux clux added this to the 0.87.0 milestone Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1295 (141c2f7) into main (83368df) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   72.31%   72.30%   -0.02%     
==========================================
  Files          75       75              
  Lines        6347     6347              
==========================================
- Hits         4590     4589       -1     
- Misses       1757     1758       +1     
Files Changed Coverage Δ
kube-client/src/discovery/apigroup.rs 89.90% <ø> (ø)

... and 1 file with indirect coverage changes

@clux clux merged commit 7ef858d into main Oct 5, 2023
17 checks passed
@clux clux deleted the api-version-preference-warning branch October 5, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiGroup::recommended_kind returns None while I expected Some(_)
1 participant