Ease the bound for reflector to only request identifying metadata
#1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
force-pushed
the
reflector-toobjectref
branch
from
ceccb8c to
6850d11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
=======================================
+ Coverage 72.1% 72.2% +0.1%
=======================================
Files 75 75
Lines 6470 6485 +15
=======================================
+ Hits 4663 4680 +17
+ Misses 1807 1805 -2
|
Fixes kube-rs#1389 Signed-off-by: SOFe <sofe2038@gmail.com>
SOF3
force-pushed
the
reflector-toobjectref
branch
from
6850d11 to
298e834
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
SOF3
added a commit
to SOF3/kube-rs
that referenced
this pull request
Feb 11, 2024
Motivation explained in kube-rs#1389 Depends on kube-rs#1393 to ease reflector bounds
SOF3
added a commit
to SOF3/kube-rs
that referenced
this pull request
Feb 11, 2024
Motivation explained in kube-rs#1389 Depends on kube-rs#1393 to ease reflector bounds
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
SOF3
added a commit
to SOF3/kube-rs
that referenced
this pull request
Feb 12, 2024
Motivation explained in kube-rs#1389 Depends on kube-rs#1393 to ease reflector bounds Signed-off-by: SOFe <sofe2038@gmail.com>
clux
reviewed
Feb 22, 2024
Signed-off-by: SOFe <sofe2038@gmail.com>
SOF3
force-pushed
the
reflector-toobjectref
branch
from
57e141e to
a79d1f4
Compare
|
Renamed to clippy_nightly is failing due to GitHub permission issues, not relevant to this PR. |
clux
reviewed
Mar 4, 2024
Co-authored-by: Eirik A <sszynrae@gmail.com> Signed-off-by: Jonathan Chan Kwan Yin <sofe2038@gmail.com>
clux
approved these changes
Mar 5, 2024
Signed-off-by: Jonathan Chan Kwan Yin <sofe2038@gmail.com>
SOF3
added a commit
to SOF3/kube-rs
that referenced
this pull request
Mar 9, 2024
Motivation explained in kube-rs#1389 Depends on kube-rs#1393 to ease reflector bounds Signed-off-by: SOFe <sofe2038@gmail.com>
SOF3
added a commit
to SOF3/kube-rs
that referenced
this pull request
May 8, 2024
Motivation explained in kube-rs#1389 Depends on kube-rs#1393 to ease reflector bounds Signed-off-by: SOFe <sofe2038@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389, see issue for details