Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: document scope footgun in watch_object #1510

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

clux
Copy link
Member

@clux clux commented Jun 4, 2024

it is possible to use Api::all with a namespaced object with watch_object which can lead to duplicate matches.

This is not desirable and we can't avoid this directly (for at least as long as we use Api and not client_ext in this fn), so have added a warning to the function.

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added changelog-fix changelog fix category for prs changelog-exclude changelog excluded prs and removed changelog-fix changelog fix category for prs labels Jun 4, 2024
@clux clux added this to the 0.92.0 milestone Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1%. Comparing base (6ce3978) to head (61b324d).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1510     +/-   ##
=======================================
+ Coverage   75.1%   75.1%   +0.1%     
=======================================
  Files         78      78             
  Lines       6864    6865      +1     
=======================================
+ Hits        5150    5151      +1     
  Misses      1714    1714             
Files Coverage Δ
kube-runtime/src/watcher.rs 42.0% <100.0%> (+0.3%) ⬆️

@clux clux marked this pull request as ready for review June 4, 2024 11:50
@clux clux merged commit 7ee3298 into main Jun 5, 2024
17 checks passed
@clux clux deleted the watch_object_scope branch June 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants