Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example on predicate usage for shared streams #1552

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Aug 1, 2024

Motivation

Provide an example for event filtering, while leaving original watch stream unmodified. May be useful for sharding controller logic, where reconcile is only needed in case of a specific change.

Solution

Potentially looking for better suggestions to approach topic of comparing previous and current resource state.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4%. Comparing base (7ff120a) to head (0eec3ab).
Report is 4 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1552   +/-   ##
=====================================
  Coverage   75.4%   75.4%           
=====================================
  Files         80      80           
  Lines       7290    7290           
=====================================
  Hits        5495    5495           
  Misses      1795    1795           

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev force-pushed the shared-predicate-filter-example branch from bdbb2e5 to 0eec3ab Compare August 15, 2024 10:52
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response on this.

I was a bit unsure of what to do here because we are a bit sure of how the multiplexing for shared streams should actually interact with stream extensions (from WatchStreamExt) and we haven't really done that investigation properly yet. Happy to merge as is and resolve that at a later date though personally.

@clux clux added the docs unclear documentation label Aug 25, 2024
@clux clux added this to the 0.94.0 milestone Aug 25, 2024
@clux clux merged commit 34870b1 into kube-rs:main Sep 6, 2024
17 checks passed
@clux clux added the changelog-exclude changelog excluded prs label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs docs unclear documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants