Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove using HTTP PROXY from environment variable #1587

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

aviramha
Copy link
Contributor

remove using HTTP PROXY from environment variable, matching kubectl's behavior.

I found out that kubectl doesn't care for the HTTP_PROXY environment variable, probably for security reasons (a way to have plaintext requests?)

… behavior

Signed-off-by: Aviram Hassan <aviramyhassan@gmail.com>
@aviramha aviramha force-pushed the adjust_http_proxy_behavior branch from bb73590 to 08fda05 Compare September 23, 2024 06:25
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (c0fe0c8) to head (08fda05).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1587     +/-   ##
=======================================
- Coverage   75.3%   75.3%   -0.0%     
=======================================
  Files         82      82             
  Lines       7331    7329      -2     
=======================================
- Hits        5519    5517      -2     
  Misses      1812    1812             
Files with missing lines Coverage Δ
kube-client/src/config/file_loader.rs 85.8% <ø> (-0.5%) ⬇️

@clux clux added the changelog-change changelog change category for prs label Sep 23, 2024
@clux clux added this to the 0.96.0 milestone Sep 23, 2024
@clux
Copy link
Member

clux commented Sep 23, 2024

This sounds sensible to me if the go side does not do it.
CC @goenning who currently has a related issue under #1203.

@goenning
Copy link
Contributor

Ship it :)

@clux clux merged commit 0fa32b8 into kube-rs:main Sep 23, 2024
17 checks passed
@aviramha aviramha deleted the adjust_http_proxy_behavior branch September 29, 2024 06:38
@clux clux added changelog-remove changelog remove category for prs and removed changelog-change changelog change category for prs labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-remove changelog remove category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants