Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument the Api and propagate required Debug impls #455

Merged
merged 7 commits into from
Mar 12, 2021
Merged

Conversation

clux
Copy link
Member

@clux clux commented Mar 8, 2021

Experiment with tracing primarily for use with the example controller-rs repo via kube-rs/controller-rs#10

@clux clux mentioned this pull request Mar 9, 2021
3 tasks
@clux
Copy link
Member Author

clux commented Mar 9, 2021

I might flesh this out more, but happy to take some comments here now.

@clux clux marked this pull request as ready for review March 9, 2021 21:08
kube/src/lib.rs Outdated Show resolved Hide resolved
@clux
Copy link
Member Author

clux commented Mar 11, 2021

Span result:
Screenshot from 2021-03-11 10-54-53

  • One span around the Api call with non-self parameters traced as tags for timing information
  • One trace log from kube::service::log for KUBE=trace enabled stdout users

And importantly, tracing automatically associates the two.

@clux
Copy link
Member Author

clux commented Mar 11, 2021

Probably merging this tomorrow unless there are any objections.

The only thing that I feel is possibly contentious here is the extra Debug requirements (and we might be able to elide some of that in the future judging from the valuable channel), but for now, they are needed to drop kube parameters into trace values.

@clux clux merged commit 698f421 into master Mar 12, 2021
@clux clux deleted the tracing-test branch March 12, 2021 14:22
@clux clux linked an issue Mar 12, 2021 that may be closed by this pull request
3 tasks
@clux clux removed a link to an issue Mar 12, 2021
3 tasks
@clux
Copy link
Member Author

clux commented Mar 31, 2021

Released in 0.52.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant