Rewrite dynamic api example #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example now shows how one can use kube to inspect arbitrary resources.
clux
approved these changes
Mar 18, 2021
examples/dynamic_api.rs
Outdated
| None => { | ||
| println!("\t\t{}", name); | ||
| } | ||
| } |
There was a problem hiding this comment.
The DynamicObject implements Meta now, right. We can use Meta::name and Meta::namespace here for a one-liner?
clux
reviewed
Mar 18, 2021
examples/dynamic_api.rs
Outdated
| } | ||
| println!("\t{}", ar.kind); | ||
| let api = DynamicResource::from_api_resource(&ar, &apis.group_version) | ||
| .into_api::<DynamicObject>(client.clone()); |
There was a problem hiding this comment.
is anything here dealing with namespaces, or is it just cluster / all querying?
There was a problem hiding this comment.
We are listing objects from all namespaces.
I will add an option to only list resources from one namespace.
|
Did a small cleanup to it in master to remove the special casing after we merged #470. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example now shows how one can use kube to inspect arbitrary
resources.