Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up type bounds after Metapocalypse #469

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Clean up type bounds after Metapocalypse #469

merged 2 commits into from
Mar 19, 2021

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 18, 2021

#385 added a bunch of constraints on Meta::Family that weren't actually needed. We might as well loosen them back.

@nightkr nightkr requested a review from clux March 18, 2021 19:19
clux
clux approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much nicer. I did worry about the complexity of the runtime internals a bit when merging that.

@clux clux merged commit 7615b13 into kube-rs:master Mar 19, 2021
@nightkr nightkr deleted the chore/runtime-meta-cleanup branch March 19, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nightkr @clux @kazk