Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize kube::Error changes #713

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

kazk
Copy link
Member

@kazk kazk commented Nov 16, 2021

Motivation

Make the changelog less overwhelming for average users (#709 (comment))

Solution

Summarized the changes to kube::Error and moved the original in <details>.

Signed-off-by: kazk <kazk.dev@gmail.com>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nice use of a collapsible comment :-)

@kazk kazk merged commit 6f09e6c into kube-rs:master Nov 16, 2021
@kazk kazk deleted the summarize-kube-error-changes branch November 16, 2021 20:52
@clux
Copy link
Member

clux commented Nov 16, 2021

Sounds like we are good for a minor release. Want me to do one?

@clux
Copy link
Member

clux commented Nov 16, 2021

(Waiting for rustls also seems sensible here, but no problem to do another minor.)

@kazk
Copy link
Member Author

kazk commented Nov 16, 2021

Yeah, I think we can cut a new release. I can remove Error::RustlsTls from the changelog later.

@clux
Copy link
Member

clux commented Nov 16, 2021

I can remove that one line before release. Need to commit to master anyway.

@clux
Copy link
Member

clux commented Nov 16, 2021

Ok, all done. 0.64.0 is out.
f9bfe11 is the removed line.

Thanks again for all the great error work this release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants