Export Version / Unicode in parsing #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See kube-rs#764 (comment) Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
nightkr
force-pushed
the
version-export-/unicode-parsing
branch
from
fed4850 to
9069649
Compare
This comment has been minimized.
This comment has been minimized.
clux
approved these changes
Dec 26, 2021
clux
added a commit
that referenced
this pull request
Dec 27, 2021
* Export Version parser with Ord impl in kube_core doing the cleanup steps described to make this worthy of exporting. needed for kube-rs/kopium#23 Signed-off-by: clux <sszynrae@gmail.com> * remove leftover TODO + improve doc links between discovery and core Signed-off-by: clux <sszynrae@gmail.com> * import more tests, fix one, better docs Signed-off-by: clux <sszynrae@gmail.com> * a bit less Reverse and less double negatives Signed-off-by: clux <sszynrae@gmail.com> * Version export - explicitly request ordering (#767) * Explicitly request which ordering to use Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se> * Add `Version::latest` that includes considers v2 > v2beta1 > v1 Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se> * Rename Version::latest_stable to priority Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se> * Also rename LatestStable accordingly Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se> * rename latest to semantic for language consistency we had two orders ::latest and ::priority, but v.latest() was a ambiguous. v.latest could mean: - we are sorting by age (but that's not true) - we are sorting by latest version in semver semantics (true so think v.semantic() is slightly more clear. v2.semantic() > v1.semantic() feels a little easier to comprehend than v2.latest() > v1.latest() Signed-off-by: clux <sszynrae@gmail.com> * fix self-references and rename semantic to distance Signed-off-by: clux <sszynrae@gmail.com> * rename to generation Signed-off-by: clux <sszynrae@gmail.com> * We need to split on byte lengths, not code point counts (#772) See #764 (comment) Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se> * Apply suggestions from code review Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de> * Update kube-core/src/version.rs Co-authored-by: kazk <kazk.dev@gmail.com> Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de> Co-authored-by: kazk <kazk.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #764 (comment)