Fix schemas containing both properties and additionalProperties #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o serde(flatten) See also: kube-rs#844 Signed-off-by: Julius Michaelis <gitter@liftm.de>
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
+ Coverage 70.31% 70.39% +0.07%
==========================================
Files 59 59
Lines 4184 4195 +11
==========================================
+ Hits 2942 2953 +11
Misses 1242 1242
Continue to review full report at Codecov.
|
clux
approved these changes
Mar 24, 2022
Co-authored-by: Eirik A <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844 with a second rewrite rule in
StructuralSchemaRewriter.(Note: This doesn't work for
#[serde(flatten)] foo: serde_json::Value. But I think that's the wrong thing to flatten anyway.)