-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GroupVersion::with_kind and TypeMeta -> GroupVersionKind converters #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for working with kubernetes disk format. Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
that referenced
this pull request
May 4, 2022
Can apply yaml from multidoc files using helpers from #896 Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 70.35% 70.47% +0.11%
==========================================
Files 62 62
Lines 4264 4281 +17
==========================================
+ Hits 3000 3017 +17
Misses 1264 1264
|
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
kazk
reviewed
May 4, 2022
Signed-off-by: clux <sszynrae@gmail.com>
kazk
approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title needs to be updated.
Signed-off-by: clux <sszynrae@gmail.com>
clux
changed the title
Add GroupVersion::with_kind and GroupVersionKind::from_yaml helpers
Add GroupVersion::with_kind and TypeMeta -> GroupVersionKind converters
May 5, 2022
clux
added a commit
that referenced
this pull request
May 5, 2022
Can apply yaml from multidoc files using helpers from #896 Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
that referenced
this pull request
May 6, 2022
Can apply yaml from multidoc files using helpers from #896 Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
that referenced
this pull request
May 11, 2022
* Extend kubectl with apply method Can apply yaml from multidoc files using helpers from #896 Signed-off-by: clux <sszynrae@gmail.com> * rebase with new helpers Signed-off-by: clux <sszynrae@gmail.com> * extra error case Signed-off-by: clux <sszynrae@gmail.com> * add edit support as well ok i will stop now. this is surprisingly easy. Signed-off-by: clux <sszynrae@gmail.com> * avoid awkward cloning Signed-off-by: clux <sszynrae@gmail.com> * managed fields tweak Signed-off-by: clux <sszynrae@gmail.com> * add note after finding out kubectl is smart Signed-off-by: clux <sszynrae@gmail.com> * less import after rebase Signed-off-by: clux <sszynrae@gmail.com> * cleanup into methods on clap inst Signed-off-by: clux <sszynrae@gmail.com> * cleanup dynamic_api example a bit no need to use NAMESPACE evars. people can use kns or similar to change namespace. rely on default_namespaced. Signed-off-by: clux <sszynrae@gmail.com> * remove NAMESPACE evars across examples + configmap_watcher better to let people rely on default_namespaced and switch with kns also updates docs for these Signed-off-by: clux <sszynrae@gmail.com> * fix log_stream example Signed-off-by: clux <sszynrae@gmail.com> * fix warning + build Signed-off-by: clux <sszynrae@gmail.com> * make verb an enum Signed-off-by: clux <sszynrae@gmail.com> * one less clone and tweak sentence Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more efficiently working with kubernetes disk format.
was kind of boilerplatey to do elsewhere.