-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added iter
methods to ObjectList
#91
Conversation
This is solid. Examples are really good, code is clean. Just a few typos in there that causes CI to fail atm. Will definitely merge this when it passes, but I just have a small request: change the pod_openapi.rs example to use the simpler iterator. it's currently doing a |
|
||
mod metadata; | ||
pub use self::metadata::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add ListMeta
to the public exports for use in the example in the docs on the new iter
methods, is this okay or should I just cut out the examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should probably be public anyway 👍
thanks for pointing it out though. the re-formatting made that hard to spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Released in kube 0.20.0 :-) |
Awesome thanks! There's a good chance I pick at a couple other issues as well, rust and kuberentes are two of my favorite things and this project is awesome 🦀 |
Added
iter
anditer_mut
methods toObjectList
to provide Iterators, as well as implementations ofIntoIterator
forObjectList
,&ObjectList
and&mut ObjectList
#41