Exlude invalid IPs when range crosses the third octet #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was hitting this when running `make build` on main: ``` ... # github.com/kube-vip/kube-vip-cloud-provider/pkg/provider pkg/provider/provider.go:83:22: not enough arguments in call to newLoadBalancer have (*kubernetes.Clientset, string, string) want (*kubernetes.Clientset, string, string, string) make: *** [Makefile:28: kube-vip-cloud-provider] Error 2 ``` `serviceCidr` isn't used in this function so I removed it so `make build` can successfully complete again. Signed-off-by: AshleyDumaine <ashley.dumaine@gmail.com>
Signed-off-by: Constantin Galbenu <xprt64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a range that crosses the third octet, there are 2 IPs that shouldn't be used: the ones that end in 255 or 0.
There is also a test that catch this situation and that fails; this PR pass it: "single range, across third octet" in
ipam_test.go.