Support descending search order #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wu Sendong <wusendong@live.com>
Signed-off-by: Wu Sendong <wusendong@live.com>
wusendong
force-pushed
the
feat/descending_order
branch
from
e7fa7a9 to
905578a
Compare
|
Minor nit, but a fantastic addition! |
wusendong
force-pushed
the
feat/descending_order
branch
from
1430562 to
22b1f2a
Compare
Signed-off-by: Wu Sendong <wusendong@live.com>
Signed-off-by: Wu Sendong <wusendong@live.com>
wusendong
force-pushed
the
feat/descending_order
branch
from
baedca2 to
255e0fb
Compare
|
For these changes, I have tested in my RKE2 cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the official documentation on service-ip-static-sub-range , Kubernetes prefers to allocate dynamic IP addresses to Services by choosing from the upper band.
I've come up with a similar situation, where existing servers are already occupying the lower IP segments, so in order to minimize conflicts, dynamic IP allocation should be in descending order of precedence.
The PR also fix cidr network should ignore NetworkID and BroadcastIP which some cidr network's BroadcastIP is not xxx.xxx.xxx.255.