Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This allows prometheus configuration to be specified in the cli #883

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

thebsdbox
Copy link
Collaborator

--prometheusHTTPServer "" will now create

    - name: prometheus_server

with no - value, which should stop prometheus from starting.

Signed-off-by: Dan Finneran <daniel.finneran@gmail.com>
@thebsdbox
Copy link
Collaborator Author

Fix for #630

@thebsdbox thebsdbox merged commit 69f4c38 into kube-vip:main Jun 21, 2024
8 of 9 checks passed
@thebsdbox thebsdbox deleted the prometheus_fix branch June 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant