Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): fix bug #1038 #1044

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

achrefbensaad
Copy link
Member

Purpose of PR?:

Fixes #1038

Does this PR introduce a breaking change? No

If the changes in this PR are manually verified, list down the scenarios covered:: see bug description.

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Signed-off-by: Achref ben saad <achref@accuknox.com>
Copy link
Collaborator

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
apart from auto-testing framework passing in CI, i manually tested the annotated namespace cases.

@achrefbensaad achrefbensaad merged commit 90c3f52 into kubearmor:main Jan 13, 2023
daemon1024 added a commit to daemon1024/KubeArmor that referenced this pull request Oct 18, 2023
Ref kubearmor#1044

Remove the gosec include once we handle kubearmor#1464

Signed-off-by: daemon1024 <barun1024@gmail.com>
daemon1024 added a commit to daemon1024/KubeArmor that referenced this pull request Oct 18, 2023
Ref kubearmor#1044

Remove the gosec exclude once we handle kubearmor#1464

Signed-off-by: daemon1024 <barun1024@gmail.com>
daemon1024 added a commit to daemon1024/KubeArmor that referenced this pull request Oct 18, 2023
Ref kubearmor#1044

Remove the gosec exclude once we handle kubearmor#1464

Signed-off-by: daemon1024 <barun1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeArmor not generating alert for policy violation if default posture is audit
2 participants