fix(cert): read ca crt file only with externalcertloader #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rksharma95
requested review from
achrefbensaad,
daemon1024 and
DelusionalOptimist
daemon1024
approved these changes
Feb 29, 2024
|
Ref #1464 |
achrefbensaad
approved these changes
Mar 4, 2024
Signed-off-by: rksharma95 <ramakant@accuknox.com>
daemon1024
force-pushed
the
fix-certloader-bug
branch
from
f7c00f5
to
14d4d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
when externalcertloader is being used to load certificates provided externally using files, for CA it requires only certificate file to be read to add it to the certpool.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>