-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): use rbac rules conditionally using flag #1940
Merged
Prateeknandle
merged 2 commits into
kubearmor:main
from
rksharma95:conditional-rbac-rules
Jan 17, 2025
Merged
fix(operator): use rbac rules conditionally using flag #1940
Prateeknandle
merged 2 commits into
kubearmor:main
from
rksharma95:conditional-rbac-rules
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rksharma95
force-pushed
the
conditional-rbac-rules
branch
from
January 15, 2025 11:15
d5ffd91
to
ac5bb4e
Compare
daemon1024
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
rksharma95
force-pushed
the
conditional-rbac-rules
branch
from
January 15, 2025 14:52
ac5bb4e
to
2f526ea
Compare
rksharma95
force-pushed
the
conditional-rbac-rules
branch
from
January 15, 2025 17:08
2f526ea
to
fd2e653
Compare
kubearmor conditionally annotates resources using flag -annotateResource add a deployment time flag to operator helm chart and use this flag to conditionally assign RBAC permissions to kubearmor and operator serviceaccounts. additionally use role instead of clusterole to manage kubearmor k8s resources in target namespace with operator. Signed-off-by: rksharma95 <ramakant@accuknox.com>
Signed-off-by: rksharma95 <ramakant@accuknox.com>
rksharma95
force-pushed
the
conditional-rbac-rules
branch
from
January 16, 2025 07:52
fd2e653
to
38f7f48
Compare
daemon1024
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏽
Prateeknandle
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
kubearmor conditionally annotates resources using flag
-annotateResource
this PR adds a deployment time flagkubearmorOperator.annotateResource
to operator helm chart and use this flag to conditionally assign RBAC permissions to kubearmor and operator serviceaccounts.additionally use role instead of clusterole to manage kubearmor k8s resources in target namespace with operator.
Fixes #1939
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Checklist:
<type>(<scope>): <subject>