Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make Action work without old summary path #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhy76
Copy link
Contributor

@zhy76 zhy76 commented Aug 23, 2023

feat: Make Action work without old summary path
Fixes: #17

Signed-off-by: zhy76 <958474674@qq.com>
@zhy76
Copy link
Contributor Author

zhy76 commented Aug 23, 2023

PTAL,Thanks~ @daemon1024

@daemon1024
Copy link
Member

Why are the actions failing?

@zhy76
Copy link
Contributor Author

zhy76 commented Aug 24, 2023

  /usr/bin/git push origin gh-pages
  remote: Permission to kubearmor/kubearmor-action.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/kubearmor/kubearmor-action.git/': The requested URL returned error: 403
  Error: Action failed with "The process '/usr/bin/git' failed with exit code 128"

no permission for github action to push image or report json file to branch gh-page:
We should follow this:peaceiris/actions-gh-pages#742 (comment)

@daemon1024
Copy link
Member

Noting need to check permission denied issues.

@zhy76
Copy link
Contributor Author

zhy76 commented Sep 1, 2023

I found why there is no permission for my action bot:peaceiris/actions-gh-pages#339 (comment)
I ask the author:peaceiris/actions-gh-pages#972 (comment), so maybe we can let user to decide where to save their summary report file and picture for url.

@daemon1024
Copy link
Member

@zhy76 Yes. But can we add something here such that it works on PRs?

@zhy76
Copy link
Contributor Author

zhy76 commented Sep 3, 2023

@zhy76 Yes. But can we add something here such that it works on PRs?

The PR error is that I don't have push permissions, and I haven't figured out how to fix it unless we have a public store to use as a graph bed. Do you have any suggestions?

@zhy76
Copy link
Contributor Author

zhy76 commented Sep 5, 2023

I thought of a way, maybe we can store the files in fork's repository, let me give it a try.

@zhy76 zhy76 force-pushed the old-path branch 2 times, most recently from 70e05ed to 4cef518 Compare September 5, 2023 02:28
Signed-off-by: zhy76 <958474674@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Action work without old summary path
2 participants