feat: add limit flag #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
daemon1024
reviewed
Apr 18, 2022
nyrahul
approved these changes
Apr 22, 2022
|
|
||
| } else { | ||
| for fd.Running { | ||
| res, err := fd.alertStream.Recv() |
There was a problem hiding this comment.
Is the possible to remove this code duplication ... I mean Recv() ... watchAlertsHelper()
There was a problem hiding this comment.
I think currently only code duplication section is this one
res, err := fd.logStream.Recv()
if err != nil {
fmt.Printf("Failed to receive an alert (%s)\n", err.Error())
break
}
_ = WatchLogsHelper(res, o)
I tried to add it in another function ... but it didn't help
|
Can you please fix the conflict by rebasing and please check the review comment ? Thanks |
daemon1024
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slayer321 sachin.maurya7666@gmail.com
add limit flag
related issue #40
cc @nyrahul @daemon1024