Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the image type can not be saved when saving cluster as a template #108

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

lysign
Copy link
Collaborator

@lysign lysign commented Aug 16, 2022

Signed-off-by: liuying liu.ying@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #76

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: liuying <liu.ying@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@lysign: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #108 (dea4242) into master (ff89e95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files           6        6           
  Lines         552      552           
  Branches      152      152           
=======================================
  Hits          262      262           
  Misses        227      227           
  Partials       63       63           

Copy link
Collaborator

@moweiwei moweiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e3e2e12249620c5bdbcc8c660d91431964df4268

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysign, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@lysign
Copy link
Collaborator Author

lysign commented Aug 16, 2022

/cherrypick release-1.1

@kubeclipper-bot kubeclipper-bot merged commit 26d59e8 into kubeclipper:master Aug 16, 2022
@kubeclipper-bot
Copy link
Collaborator

@lysign: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@lysign: new pull request created: #109

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The image type can not be saved when saving cluster as a template
4 participants