Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expiration tag in cluster list #167

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

lysign
Copy link
Collaborator

@lysign lysign commented Sep 22, 2022

Signed-off-by: liuying liu.ying@99cloud.net

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #166

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

@lysign: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #167 (e704bf1) into master (d7648f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   46.95%   46.95%           
=======================================
  Files           6        6           
  Lines         558      558           
  Branches      154      154           
=======================================
  Hits          262      262           
  Misses        231      231           
  Partials       65       65           

@kubeclipper-bot kubeclipper-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2022
Signed-off-by: liuying <liu.ying@99cloud.net>
Copy link
Collaborator

@moweiwei moweiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e6ed9fd2602a79e0ac0aedfa688936cea1d69ed9

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysign, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@kubeclipper-bot kubeclipper-bot merged commit 75fafb2 into kubeclipper:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After the certificate expires, the certificate expiration prompt is displayed in the cluster list
4 participants