Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix versionCross error #314

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

moweiwei
Copy link
Collaborator

@moweiwei moweiwei commented Dec 5, 2022

Signed-off-by: moweiwei mo.weiwei@99cloud.net

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:


Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@moweiwei: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2022
@moweiwei
Copy link
Collaborator Author

moweiwei commented Dec 5, 2022

cherrypick-master

@lysign
Copy link
Collaborator

lysign commented Dec 5, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0dc4a87f866d6e25995b3a380b8c7420343a3e3c

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysign, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moweiwei
Copy link
Collaborator Author

moweiwei commented Dec 5, 2022

/cherrypick master

@kubeclipper-bot
Copy link
Collaborator

@moweiwei: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

Merging #314 (bc30634) into release-1.3 (2af56d5) will increase coverage by 1.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3     #314      +/-   ##
===============================================
+ Coverage        46.20%   47.35%   +1.15%     
===============================================
  Files                7        7              
  Lines              606      606              
  Branches           171      171              
===============================================
+ Hits               280      287       +7     
+ Misses             252      246       -6     
+ Partials            74       73       -1     
Impacted Files Coverage Δ
src/utils/index.js 30.34% <100.00%> (+2.16%) ⬆️

@moweiwei moweiwei merged commit d1d52de into kubeclipper:release-1.3 Dec 5, 2022
@kubeclipper-bot
Copy link
Collaborator

@moweiwei: new pull request created: #315

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants