Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the storageclass form used by select or input #377

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

lysign
Copy link
Collaborator

@lysign lysign commented Feb 27, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #376

Special notes for reviewers:


Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: liuying <liu.ying@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@lysign: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lysign
To complete the pull request process, please assign wu-wenxiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @wu-wenxiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #377 (39adeba) into release-1.3 (c5bff4e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.3     #377   +/-   ##
============================================
  Coverage        47.35%   47.35%           
============================================
  Files                7        7           
  Lines              606      606           
  Branches           171      171           
============================================
  Hits               287      287           
  Misses             246      246           
  Partials            73       73           

@moweiwei moweiwei merged commit c18ca52 into kubeclipper:release-1.3 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants