Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add kube-console on release kc-console #409

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: add kube-console on release kc-console #409

merged 1 commit into from
Sep 5, 2023

Conversation

sacredartr
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:


Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: sacredartr <zhou.hao@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@sacredartr: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #409 (c2c815e) into master (fc658ad) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files           7        7           
  Lines         608      608           
  Branches      171      171           
=======================================
  Hits          289      289           
  Misses        246      246           
  Partials       73       73           

@x893675
Copy link
Collaborator

x893675 commented Sep 5, 2023

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sacredartr, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9c2c9226e92c1b022c30310a10cb6eec3b806987

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@kubeclipper-bot kubeclipper-bot merged commit 6f50466 into kubeclipper:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants