Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix template offline field error #95

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

moweiwei
Copy link
Collaborator

@moweiwei moweiwei commented Aug 13, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #76

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f02ef21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #95   +/-   ##
=========================================
  Coverage          ?   47.46%           
=========================================
  Files             ?        6           
  Lines             ?      552           
  Branches          ?      152           
=========================================
  Hits              ?      262           
  Misses            ?      227           
  Partials          ?       63           

Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
@x893675
Copy link
Collaborator

x893675 commented Aug 13, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 768eb3fb54e49b444a0b777387758ceaa444d624

@kubeclipper-bot kubeclipper-bot merged commit 8afd8bb into kubeclipper:master Aug 13, 2022
@moweiwei moweiwei deleted the fix_template branch November 25, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The image type can not be saved when saving cluster as a template
4 participants