Add ingestion config for standard discount #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvn
reviewed
Sep 4, 2024
thomasvn
reviewed
Sep 4, 2024
thomasvn
reviewed
Sep 4, 2024
thomasvn
reviewed
Sep 4, 2024
thomasvn
approved these changes
Sep 4, 2024
kaelanspatel
added a commit
that referenced
this pull request
Sep 4, 2024
* Add ingestion config for standard discount * Remove statefulset check in ingestionconfig * Fix nil in ingestion config * Fix nil in _helpers.tpl for standard discount * Re-add statefulset check in ingestionconfig
Merged
thomasvn
pushed a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds configmap handling and env to support standard discount in aggregator (see linked PR).
Does this PR rely on any other PRs?
https://github.com/kubecost/kubecost-cost-model/pull/2668
How does this PR impact users? (This is the kind of thing that goes in release notes!)
See linked PR
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2412
What risks are associated with merging this PR? What is required to fully test this PR?
See linked PR
How was this PR tested?
See linked PR
Have you made an update to documentation? If so, please provide the corresponding PR.