[ENG-2691] Set up InstanceAllowLists ConfigMap #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-kc
approved these changes
Aug 23, 2024
ameijer
approved these changes
Aug 23, 2024
biancaburtoiu
force-pushed
the
biancaburtoiu/eng-2691
branch
from
9d8d411
to
6533792
Compare
biancaburtoiu
added a commit
that referenced
this pull request
Aug 28, 2024
Merged
biancaburtoiu
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR introduces support for users to supply custom allow lists at CSP level, to be then used in Savings Recommendations (cluster/node group right-sizing).
Does this PR rely on any other PRs?
KCM PR: https://github.com/kubecost/kubecost-cost-model/pull/2712
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users can now supply custom allow lists at CSP level to be then used in Savings Recommendations (cluster/node group right-sizing).
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2691
What risks are associated with merging this PR? What is required to fully test this PR?
This config is optional, no risks associated.
How was this PR tested?
Ensure ConfigMap is created correctly via
helm templateHave you made an update to documentation? If so, please provide the corresponding PR.
This update will need public docs tracked in this ticket: https://kubecost.atlassian.net/browse/ENG-2729