Skip to content

Commit

Permalink
Remove broker and controller service kafka helpers
Browse files Browse the repository at this point in the history
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
  • Loading branch information
obaydullahmhs committed Nov 22, 2023
1 parent 88ab93c commit 15523cf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
8 changes: 3 additions & 5 deletions apis/kubedb/v1alpha2/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -518,15 +518,13 @@ const (
KafkaPortNameCruiseControlREST = "cc-rest"
KafkaBrokerClientPortName = "broker"
KafkaControllerClientPortName = "controller"
KafkaPortNameInternal = "internal"
KafkaPortNameExternal = "external"
KafkaPortNameLocal = "local"
KafkaTopicNameHealth = "kafka-health"
KafkaTopicDeletionThresholdOffset = 1000
KafkaControllerMaxID = 1000
KafkaBrokerMaxID = 1000
KafkaRESTPort = 9092
KafkaControllerRESTPort = 9093
KafkaInternalRESTPort = 29092
KafkaExternalRESTPort = 19092
KafkaLocalRESTPort = 29092
KafkaCruiseControlRESTPort = 9090
KafkaCruiseControlListenerPort = 9094
KafkaCCDefaultInNetwork = 500000
Expand Down
8 changes: 0 additions & 8 deletions apis/kubedb/v1alpha2/kafka_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,6 @@ func (k *Kafka) GoverningServiceName() string {
return meta_util.NameWithSuffix(k.ServiceName(), "pods")
}

func (k *Kafka) GoverningServiceNameController() string {
return meta_util.NameWithSuffix(k.ServiceName(), KafkaNodeRolesController)
}

func (k *Kafka) GoverningServiceNameBroker() string {
return meta_util.NameWithSuffix(k.ServiceName(), KafkaNodeRolesBrokers)
}

func (k *Kafka) GoverningServiceNameCruiseControl() string {
return meta_util.NameWithSuffix(k.ServiceName(), KafkaNodeRolesCruiseControl)
}
Expand Down
3 changes: 1 addition & 2 deletions apis/kubedb/v1alpha2/kafka_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,7 @@ type KafkaListenerType string
const (
KafkaListenerBroker KafkaListenerType = "BROKER"
KafkaListenerController KafkaListenerType = "CONTROLLER"
KafkaListenerInternal KafkaListenerType = "INTERNAL"
KafkaListenerExternal KafkaListenerType = "EXTERNAL"
KafkaListenerLocal KafkaListenerType = "LOCAL"
KafkaListenerCC KafkaListenerType = "CC"
)

Expand Down

0 comments on commit 15523cf

Please sign in to comment.