Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka external advertised listerners url constants #1057

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

obaydullahmhs
Copy link
Member

Signed-off-by: obaydullahmhs obaydullah@appscode.com

Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
apis/kubedb/v1alpha2/kafka_webhook.go Outdated Show resolved Hide resolved
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
@obaydullahmhs obaydullahmhs changed the title Add kafka external advertised listerners url constants and forbidden Env vars webhook Add kafka external advertised listerners url constants Sep 22, 2023
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raihankhan raihankhan merged commit 19d6c5b into master Sep 25, 2023
14 checks passed
@raihankhan raihankhan deleted the add-kf-cons branch September 25, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants