-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented metrics exposure for job status with labels: name, namespace, uid, status, reason #310
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 30.97% 30.92% -0.06%
==========================================
Files 108 108
Lines 7012 7024 +12
==========================================
Hits 2172 2172
- Misses 4544 4556 +12
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@13241308289 hi, thanks for your contribution, anyway some CI checks failed, would you fix it and push again ? |
yeah, I will fix it and push again |
Since the exposed metrics are dependent on specific services, it's not feasible to write test cases for them. The issue with CI is that these cases cannot be covered in tests. However, I have already employed this in our production environment. |
I got you, metrics related code is hard to cover UT, however, would you refine the go-lint hinted code and let this CI task pass? |
Signed-off-by: 张乐 <2519960931@qq.com> Signed-off-by: paradox <2519960931@qq.com>
Signed-off-by: 张乐 <2519960931@qq.com> Signed-off-by: paradox <2519960931@qq.com>
Signed-off-by: paradox <2519960931@qq.com>
okk, I understand, I modify and push again, check has paased |
Ⅰ. Describe what this PR does
feat: Implemented metrics exposure for job status with labels: name, namespace, uid, status, reason
II. Does this pull request fix one issue?
feat: #309
III. Special notes for reviewers if any.