Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented metrics exposure for job status with labels: name, namespace, uid, status, reason #310

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

13241308289
Copy link
Contributor

Ⅰ. Describe what this PR does

feat: Implemented metrics exposure for job status with labels: name, namespace, uid, status, reason

II. Does this pull request fix one issue?

feat: #309

III. Special notes for reviewers if any.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 30.92%. Comparing base (434352b) to head (ff27043).

Files Patch % Lines
pkg/metrics/job_metrics.go 0.00% 11 Missing ⚠️
pkg/job_controller/job.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   30.97%   30.92%   -0.06%     
==========================================
  Files         108      108              
  Lines        7012     7024      +12     
==========================================
  Hits         2172     2172              
- Misses       4544     4556      +12     
  Partials      296      296              
Flag Coverage Δ
unittests 30.92% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonCqk
Copy link
Collaborator

SimonCqk commented Mar 1, 2024

@13241308289 hi, thanks for your contribution, anyway some CI checks failed, would you fix it and push again ?

@13241308289
Copy link
Contributor Author

@13241308289 hi, thanks for your contribution, anyway some CI checks failed, would you fix it and push again ?

yeah, I will fix it and push again

@13241308289
Copy link
Contributor Author

@13241308289 hi, thanks for your contribution, anyway some CI checks failed, would you fix it and push again ?

Since the exposed metrics are dependent on specific services, it's not feasible to write test cases for them. The issue with CI is that these cases cannot be covered in tests. However, I have already employed this in our production environment.

@SimonCqk
Copy link
Collaborator

SimonCqk commented Mar 1, 2024

@13241308289 hi, thanks for your contribution, anyway some CI checks failed, would you fix it and push again ?

Since the exposed metrics are dependent on specific services, it's not feasible to write test cases for them. The issue with CI is that these cases cannot be covered in tests. However, I have already employed this in our production environment.

I got you, metrics related code is hard to cover UT, however, would you refine the go-lint hinted code and let this CI task pass?

Signed-off-by: 张乐 <2519960931@qq.com>
Signed-off-by: paradox <2519960931@qq.com>
Signed-off-by: 张乐 <2519960931@qq.com>
Signed-off-by: paradox <2519960931@qq.com>
Signed-off-by: paradox <2519960931@qq.com>
@13241308289
Copy link
Contributor Author

@13241308289 hi, thanks for your contribution, anyway some CI checks failed, would you fix it and push again ?

Since the exposed metrics are dependent on specific services, it's not feasible to write test cases for them. The issue with CI is that these cases cannot be covered in tests. However, I have already employed this in our production environment.

I got you, metrics related code is hard to cover UT, however, would you refine the go-lint hinted code and let this CI task pass?

okk, I understand, I modify and push again, check has paased

@SimonCqk SimonCqk merged commit b93a2b4 into kubedl-io:master Mar 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants