Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alternative locust client #46

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Add an alternative locust client #46

merged 4 commits into from
Oct 24, 2022

Conversation

YukioZzz
Copy link
Contributor

@YukioZzz YukioZzz commented Sep 30, 2022

I. What this PR does

Add locust client as an alternative, new features are as follows:

  • simpler test file (locustfile.py) that just defines how to call the server API
  • both gRPC and HTTP supported
  • load test params could be specified in yaml
  • prometheus metrics export supported

II. Why we need it

As we might want the client to perform a more customized load test to the inference server in a more simple and flexible way, an idea is to use locust as the backend so that the user can directly specify load test params or provide its own locusttest script. A demo client image based on locust is provided here.

Copy link
Collaborator

@lwangbm lwangbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. [pkg/client_locust/image.jpg] if this is used for demo, pls rmv it to the demo folder
  2. [pkg/client_locust] pls provide docs(e.g., readme) and demo here, showing how to use the new feature
  3. the pull request tittle: Add an alternative locust client. pls provide detailed description for this pull request: the motivation, new features provided, etc

@YukioZzz
Copy link
Contributor Author

  1. [pkg/client_locust/image.jpg] if this is used for demo, pls rmv it to the demo folder
  2. [pkg/client_locust] pls provide docs(e.g., readme) and demo here, showing how to use the new feature
  3. the pull request tittle: Add an alternative locust client. pls provide detailed description for this pull request: the motivation, new features provided, etc
  1. I am not sure whether should I remove [pkg/client_locust/image.jpg]. It's just like the file [pkg/client/image.jpg] and will be used by the demo client.
  2. README.md is added now, new features are as follows:
  • simpler test file needed
  • both gRPC and HTTP supported
  • load test params could be specified in yaml
  • prometheus metrics export supported
  1. I got it, changing it now
    let me know what I should further change then~ thanks for your patience.

@lwangbm lwangbm merged commit 9fb1a10 into kubedl-io:main Oct 24, 2022
ZHANGWENTAI pushed a commit to ZHANGWENTAI/morphling that referenced this pull request Oct 31, 2024
* add locust client as an alternative

* add a feature: retry if FAIL_RATIO's high

* provide both httpclient and grpcclient

* Add README.md of the locust client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants