Skip to content

test: Drain tool E2Es, UTs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Arvindthiru
Copy link
Collaborator

@Arvindthiru Arvindthiru commented Apr 18, 2025

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
@Arvindthiru Arvindthiru marked this pull request as ready for review April 21, 2025 17:49
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
@Arvindthiru Arvindthiru requested a review from michaelawyu April 21, 2025 22:47
Copy link
Member

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 files left for review; apologies for the delay.

Copy link
Member

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, PTAL. Otherwise LGTM ;) And apologies for the delay 😞

Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants