refactor: use helm lib instead of helm binary #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChenYi015
commented
Nov 16, 2024
Comment on lines
-33
to
-39
| // 1. Handle legacy training job | ||
| err := helm.DeleteRelease(jobName) | ||
| if err == nil { | ||
| log.Infof("Delete the job %s successfully.", jobName) | ||
| return nil | ||
| } | ||
| log.Debugf("%s wasn't deleted by helm due to %v", jobName, err) |
There was a problem hiding this comment.
Remove this for helm.DeleteRelease is out of date and will always return non-nil error.
Signed-off-by: Yi Chen <github@chenyicn.net>
|
Thanks for great contributions. @ChenYi015 I suggest building robust e2e testing first before refactoring the current implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Proposed changes:
arena-helmanymore.Change Category
Additional Context
helmwill still be packaged into arena-installer, as the install.sh will rename it toarena-helm.arena-helmwill only be used to install arena artifacts to k8s e.g. CRDs and various operators.