Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Check in the inference code with batching. #35

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

abcdefgs0324
Copy link
Member

@abcdefgs0324 abcdefgs0324 commented Aug 8, 2019

  • Update inference for batching.
  • Re-create images to include new code for training pipeline.

/assign @jlewi
/assign @zhenghuiwang
/assign @hamelsmu


This change is Reviewable

- Update inference.py for batching.
- Re-create images for training pipeline.
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/kubeflow/code-intelligence/pull/35

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

@k8s-ci-robot k8s-ci-robot requested a review from inc0 August 8, 2019 21:16
@zhenghuiwang
Copy link
Contributor

/lgtm

@jlewi
Copy link
Contributor

jlewi commented Aug 9, 2019

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 41c5af6 into kubeflow:master Aug 9, 2019
@abcdefgs0324 abcdefgs0324 deleted the inf_batch branch August 9, 2019 23:40
@hamelsmu
Copy link
Member

hamelsmu commented Aug 9, 2019

Label-Microservice/notebooks/inference.py is duplicated in this repository in two seperate places and should be at least be copied to the top level /py folder instead?

@abcdefgs0324 @jlewi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants