This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
Create an auto-restarter for use with skaffold. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Related to kubeflow#78 - Speedup development using skaffold file sync * Skaffold can auto sync python files to a deployed container skipping the expensive image rebuilding and deployment steps. * However, for that to work we need to restart our program when the files change. * We can't rely on Flask's autoreloader because some of our models interact poorly with Flask's debug mode. * This is a simple python program that launches another program in a subprocess. The program will also watch directories an automatically restart the subprocess if any file changes are detected.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamelsmu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to speedup development by using skaffold file sync #78 - Speedup development using
skaffold file sync
Skaffold can auto sync python files to a deployed container skipping the
expensive image rebuilding and deployment steps.
However, for that to work we need to restart our program when the files
change.
We can't rely on Flask's autoreloader because some of our models interact
poorly with Flask's debug mode.
This is a simple python program that launches another program in a subprocess.
The program will also watch directories an automatically restart the
subprocess if any file changes are detected.
This change is