Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

kustomize deployments and skaffolding for Label_MIcroservice #93

Merged
merged 1 commit into from
Jan 4, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jan 4, 2020

  • This PR provides a kustomize package to deploy the label microservice

  • Also add a skaffolding config for the Label_Microservice

  • Remove the old YAML deployment files for the Label Microservice.

  • Edit the worker Dockerfile

    • Use TensorFlow 1.15.0 rather than using the "latest" image

    • We can also use a regular TensorFlow image and not a GPU version
      since this is just for inference and so we shouldn't need GPUs

    • Create a new requirements.worker.txt to only include the libraries that
      are needed in the worker. This should be much smaller than the uber
      set of python libraries (e.g. we don't need Jupyter, fairing, etc...)

    • Create requirements.universal_model.txt to contain some of the required
      python dependencies for the universal model.

      • Universal model is using ktext and some other libraries.
  • Add a prod overlay for the issue_embedding service.

  • create_secrets.py is a helper script for creating the required secrets
    in the clusters based on files in GCS.

Related to #70 ensemble models.


This change is Reviewable

* This PR provides a kustomize package to deploy the label microservice

* Also add a skaffolding config for the Label_Microservice

* Remove the old YAML deployment files for the Label Microservice.

* Edit the worker Dockerfile

  * Use TensorFlow 1.15.0 rather than using the "latest" image
  * We can also use a regular TensorFlow image and not a GPU version
    since this is just for inference and so we shouldn't need GPUs

  * Create a new requirements.worker.txt to only include the libraries that
    are needed in the worker. This should be much smaller than the uber
    set of python libraries (e.g. we don't need Jupyter, fairing, etc...)

  * Create requirements.universal_model.txt to contain some of the required
    python dependencies for the universal model.

    * Universal model is using ktext and some other libraries.

* Add a prod overlay for the issue_embedding service.

* create_secrets.py is a helper script for creating the required secrets
  in the clusters based on files in GCS.

Related to kubeflow#70 ensemble models.
@jlewi
Copy link
Contributor Author

jlewi commented Jan 4, 2020

/assign @hamelsmu

@hamelsmu
Copy link
Member

hamelsmu commented Jan 4, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hamelsmu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 244b6eb into kubeflow:master Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants