Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Cut release-0.4 branch and cut 0.4.0 tag #153

Closed
alculquicondor opened this issue Aug 16, 2021 · 8 comments
Closed

Cut release-0.4 branch and cut 0.4.0 tag #153

alculquicondor opened this issue Aug 16, 2021 · 8 comments
Assignees

Comments

@alculquicondor
Copy link
Contributor

Sounds good. Let's cut release-0.4 branch and cut 0.4.0 tag for the new release. sounds good to you? @gaocegege

Originally posted by @Jeffwan in #150 (comment)

@alculquicondor
Copy link
Contributor Author

/assign @Jeffwan

@alculquicondor
Copy link
Contributor Author

alculquicondor commented Aug 16, 2021

Perhaps it's worth also cutting a release-0.3 branch that doesn't contain #150

@Jeffwan
Copy link
Member

Jeffwan commented Aug 17, 2021

@alculquicondor I double check the commit and seems this is not a breaking change. Do you think 0.3.x is better?

Sorry for the confusion. I didn't carefully review the change. if you are ok about 0.3.x, let's cut release-0.3 branch and 0.3.x tag then. I can help cut the tag today or tomorrow

@alculquicondor
Copy link
Contributor Author

It is partially breaking. The controllers continue working. But if there was someone using the variables from the package directly, trying to query a cluster running old controllers, their filters might not work.

We might need a 0.5 branch when we fully remove the deprecated annotations later in the future.

@Jeffwan
Copy link
Member

Jeffwan commented Aug 17, 2021

@alculquicondor
Copy link
Contributor Author

It seems to be working kubeflow/mpi-operator#409

@Jeffwan
Copy link
Member

Jeffwan commented Aug 26, 2021

Great! This can be closed.

/close

@google-oss-robot
Copy link

@Jeffwan: Closing this issue.

In response to this:

Great! This can be closed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants