Does package name github.com/stretchr/testify/assert correct ?

[merlintang]

For the test job of common,
the assert function i.e., https://github.com/stretchr/testify/assert is already moved to
https://github.com/stretchr/testify/tree/master/assert. Should we also change the related https://github.com/kubeflow/common/blob/master/job_controller/job_test.go#L9 as well ?

[issue-label-bot]

Issue-Label Bot is automatically applying the label question to this issue, with a confidence of 0.90. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[gaocegege]

Sorry, I am a little confused. Do you mean the package is moved?

[merlintang]

Sorry, I am a little confused. Do you mean the package is moved?

yes, the package name is changed. thus import old name would bring error.

[gaocegege]

We have vendored the dep, thus it may not affect us now. BTW, what's the name of the package is now? https://github.com/stretchr/testify/tree/master/assert 's package name is github.com/stretchr/testify/assert, which is same as the name in the current code.

[merlintang]

@gaocegege thanks for clarify. close this.

[merlintang]

@gaocegege I do not see the dep in the common directory, do we have prepared the vendor dep ?

[terrytangyuan]

@merlintang No we are not keeping vendor in the repo yet (currently it’s gitignored). I just opened #28 so let's discuss this separate issue there.

[merlintang]

@terrytangyuan Thanks for following up this.