Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Re organize the API package #38

Closed
jian-he opened this issue May 22, 2019 · 4 comments · Fixed by #39
Closed

Re organize the API package #38

jian-he opened this issue May 22, 2019 · 4 comments · Fixed by #39

Comments

@jian-he
Copy link
Contributor

jian-he commented May 22, 2019

Right now the user facing APIs are scattered in different packages, we should re-organize them into a central api package.
A proposal looks like below:

image

  1. types.go
  2. [new file] interface.go: the ControllerInterface for custom operators to override
  3. [new file] controller.go: the JobController struct which contains the ReconcileJobs entry method.
  4. [new file] constants.go: the constant such as the label keys: job-name, replica-index, etc.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.95. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jian-he
Copy link
Contributor Author

jian-he commented May 22, 2019

@richardsliu @johnugeorge @terrytangyuan opinions ?

@richardsliu
Copy link
Contributor

Makes sense to me.

@terrytangyuan
Copy link
Member

+1

georgkaleido pushed a commit to georgkaleido/common that referenced this issue Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants